From b04a46ac7139b0ab4b96610459856284f044efb1 Mon Sep 17 00:00:00 2001 From: NateScarlet Date: Sun, 10 Mar 2019 00:55:32 +0800 Subject: [PATCH] Refactor fetch_holidays.py --- fetch_holidays.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/fetch_holidays.py b/fetch_holidays.py index ce1b688..b6f4b86 100755 --- a/fetch_holidays.py +++ b/fetch_holidays.py @@ -5,6 +5,7 @@ import argparse import json import re from datetime import date, timedelta +from itertools import chain from typing import Iterator, List, Optional, Tuple import bs4 @@ -157,14 +158,13 @@ class SentenceParser: count = 0 text = text.replace('(', '(').replace(')', ')') - for method in self.date_extraction_methods: - for i in method(self, text): - count += 1 - is_seen = i in self.parent.date_history - self.parent.date_history.append(i) - if is_seen: - continue - yield i + for i in chain(method(self, text) for method in self.date_extraction_methods): + count += 1 + is_seen = i in self.parent.date_history + self.parent.date_history.append(i) + if is_seen: + continue + yield i if not count: raise NotImplementedError(text)